Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coinbase): transfer to wallet fix #677

Merged
merged 2 commits into from
Jan 13, 2025
Merged

fix(coinbase): transfer to wallet fix #677

merged 2 commits into from
Jan 13, 2025

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Jan 11, 2025

Issue being fixed or feature implemented

Transferring from Coinbase to wallet doesn't work

What was done?

  • Change error code that recognizes 2fa required error
  • Pass same idem for 2fa request as for the primary one

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf January 11, 2025 11:15
@Syn-McJ Syn-McJ self-assigned this Jan 11, 2025
pankcuf
pankcuf approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Syn-McJ Syn-McJ merged commit 1d4abd7 into dashpay:master Jan 13, 2025
1 check passed
@Syn-McJ Syn-McJ deleted the fix/coinbase-send branch January 13, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf pankcuf approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @pankcuf